-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The program editor cursor is off by a few lines (Chrome on MacOS) #45
Comments
This is a coding logic bug which can be resolved with some debugging. No need to remove syntax highlighting for this will send a PR for the same shortly. |
great. Looking forward to the PR. Thanks. |
I could not replicate this issue on the local machine. Please check if PR #47 fixes this as well. |
This issue is still present. To reproduce, just open the concore editor https://controlcore-project.github.io/concore-editor/ Then upload the concore folder from the concore repository and open the "concoredocker.py" (or any sufficiently long file actually), in Chrome. I have included a screenshot in the original report of this bug. You can open it to see how it looks like. |
Even after the last PR merge, the issue still exists. |
We have observed this issue on Chrome on Mac OS. |
Chrome on Windows does not have the cursor misaligned the way it is on macOS. So, this can be tricky to reproduce and fix. |
Could you please share the chrome version info and check if any fonts "Arial", "Helvetica", or sans-serif are present? Most likely, this is a font/ configuration issue, as I checked with a friend having mac and this issue doesn't appear. |
Interesting. I use the same Version 107.0.5304.87 (Official Build) (x86_64). Tested in my user profile as well as the incognito/private mode. Unlikely to be a configuration issue since I do not really use Chrome, and it remains in the default setting. As of now, I use Chrome only for the concore editor. Also, Mark found this issue first. That means both Mark and I have this issue. Just to be clear, we are testing the latest version of https://controlcore-project.github.io/concore-editor/ (not the local deployment). |
Upon digging further, I found this issue. I will spend some time looking for a workaround to fix this. Otherwise, I would change the library used for syntax highlighting. |
Great found. Thanks. |
hey @pradeeban , can you please tell me about this bug some details , not able to properly understand it from above conversation , so that I will start work upon it |
Hi @parteekcoder, You will see the curser lines being off by several lines, making the program editor unusable on Chrome on MacOS. This is bad because Chrome is our officially supported browser, and this bug makes the program editor unusable altogether on MacOS. Please let me know if that makes it clear. @Aviral09 may have more pointers. |
yeah understood , Is it only happens with large files or small too? @Aviral09 may have more pointers. "what do you mean by this" |
It happens with any file. But it will be more obvious in large files. Appears only in MacOS. This was implemented by @Aviral09. So, I mean, he may be able to give you more guidance if needed (when/if his time permits, that is). |
OK I will look into this issue |
Great. Thanks. Please make sure you have access to a Mac OS. It appears only in Mac OS, as far as I am aware. |
hey @pradeeban @Aviral09 I am not able to reproduce this issue, Are able to reproduce this issue |
Hi @parteekcoder, I can reproduce this even in your own github deployment. You need MacOS and Chrome to reproduce this. Open the demo/pm.py and highlight all the text. You will see the issue. The cursor is off by a few lines - especially noticeable in large files. |
Can you please send a small video |
It will be difficult to solve until I reproduce it |
hey @pradeeban did you find any solution for this issue? |
Just open any long program and go to the end.
Click there, and you will find the cursor is off by a couple of lines.
This is better visible when you click over the lines and highlight them.
This is confusing to the users. Is it because of the syntax highlighting module? If we can get rid of this bug by removing the syntax highlighting, that can be a better workaround.
The text was updated successfully, but these errors were encountered: