Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigDecimal type (500 Gold) #5

Open
mikera opened this issue Jan 7, 2021 · 4 comments
Open

BigDecimal type (500 Gold) #5

mikera opened this issue Jan 7, 2021 · 4 comments
Labels
bounty enhancement New feature or request

Comments

@mikera
Copy link
Member

mikera commented Jan 7, 2021

Convex maybe should support a native BigDecimal type

  • Must build upon the BigInteger type
  • Must support all integer numeric operations
  • Must maintain a decimal point position (up to long capacity)
  • Must have a strategy for ensuring values are canonical (e.g. always storing BigInteger with no trailing zeros)
  • Must be an ACell for effective CVM usage
@mikera mikera added enhancement New feature or request bounty labels Jan 7, 2021
@geofflangenderfer
Copy link

where can I find BigInteger code for reference?

@mikera
Copy link
Member Author

mikera commented Apr 26, 2021

Hi @geofflangenderfer - That's a separate bounty #4

Existing implementation exist for various fixed size numeric types, e.g. CVMDouble and CVMLong., which provide most of the boilerplate for arbitrary precision numeric classes. Also StringShort and StringTree show methods for handling arbitrary length objects on the CVM.

Probably best to jump on the Discord to discuss if you have ideas here! https://discord.com/invite/xfYGq4CT7v

@geofflangenderfer
Copy link

I get no result searching for "StringShort" or "StringTree".

I'm still unsure where to:

  • find reference material
  • map that to bounty requirements

You would get more contributions if you make it easier to jump in.

@mikera
Copy link
Member Author

mikera commented Apr 28, 2021

Hi @geofflangenderfer , we'll be opening the main Convex repository for public access in a week or two.

If you'd like advance private access that is certainly possible - but please ping me on the Discord, I would like to discuss what you are keen to do and then I can also point you to the right materials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants