Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to not force users to import IterableAccessor and BoundedIterableAccessor? #74

Open
uint opened this issue Sep 24, 2024 · 2 comments

Comments

@uint
Copy link
Collaborator

uint commented Sep 24, 2024

@webmaster128

Having to import IterableAccessor and BoundedIterableAccessor is a bit annoying for standard functionality like iterations

My intuition is this would be hard to do, but maybe there are steps we can take here. Brainstorming pending.

@webmaster128
Copy link
Member

One way this could work is to make the types in cw-storey a newtype instead of an alias. Then you can have e.g.

pub struct Column<T>(storey::containers::Column<T, crate::encoding::CwEncoding>);

and provide the best possible user experience for cw_storey::Column and keeping a lot of abstraction internal

@uint
Copy link
Collaborator Author

uint commented Sep 24, 2024

Sure, but that also increases the maintenance burden, sort of. I'm a bit hesitant there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants