Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias definition & measurement #43

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Bias definition & measurement #43

wants to merge 22 commits into from

Conversation

martinkilbinger
Copy link

A page on the definition of shear bias. Additive and multiplicative terms, population bias and individual bias.

A notebook to measure shear bias using the Pujol et al. (2017) method. Requires the shear_bias package.

"\n",
"$$a_\\alpha = \\varepsilon^{\\textrm{obs}}_\\alpha - R_{\\alpha\\alpha} g_\\alpha - \\varepsilon^{\\textrm{I}}_\\alpha .$$\n",
"\n",
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\varepsilon^{\\textrm{I}}$ is known.\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\varepsilon^{\\textrm{I}}$ is known.\n",
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\\varepsilon^{\\textrm{I}}$ is known.\n",

My bad, there should have been two \ in the change I suggested

@thuiop
Copy link

thuiop commented Apr 5, 2021

I finally took the time to properly review the PR. Overall this is a great addition to the book ; my main issue is with what scope we want to have for the book. At the moment, someone who does not know what shear is at all would be confused reading the shear bias page ; should we add an explanation of what it is, in that page or another ? In the same fashion, the word "calibration" is not defined.
Concerning the "Measuring shear" page, I have nothing to add regarding the code itself, but I think it could use some more text between the code cells, to explain what is going on and make the link with the introduction. Also, the text mentions "several methods" for measuring shear while only 1 is presented, but I guess adding others will go in other PRs.

@sfarrens sfarrens added the enhancement New feature or request label Apr 23, 2021
@martinkilbinger
Copy link
Author

I finally took the time to properly review the PR. Overall this is a great addition to the book ; my main issue is with what scope we want to have for the book. At the moment, someone who does not know what shear is at all would be confused reading the shear bias page ; should we add an explanation of what it is, in that page or another ? In the same fashion, the word "calibration" is not defined.
Concerning the "Measuring shear" page, I have nothing to add regarding the code itself, but I think it could use some more text between the code cells, to explain what is going on and make the link with the introduction. Also, the text mentions "several methods" for measuring shear while only 1 is presented, but I guess adding others will go in other PRs.

These are very good remarks. I can add some text to the notebook. I'll see what else is there in the book, it's been a while that I have not looked at it :)

In any case, the should be some place in the book that explains basic terms such as shear bias, calibration, etc.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants