-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bias definition & measurement #43
base: develop
Are you sure you want to change the base?
Conversation
…ding-Group into martin
Co-authored-by: thuiop <[email protected]>
Co-authored-by: thuiop <[email protected]>
"\n", | ||
"$$a_\\alpha = \\varepsilon^{\\textrm{obs}}_\\alpha - R_{\\alpha\\alpha} g_\\alpha - \\varepsilon^{\\textrm{I}}_\\alpha .$$\n", | ||
"\n", | ||
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\varepsilon^{\\textrm{I}}$ is known.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\varepsilon^{\\textrm{I}}$ is known.\n", | |
"This quantity can be computed in the case of image simulations where the intrinsic ellipticity $\\varepsilon^{\\textrm{I}}$ is known.\n", |
My bad, there should have been two \ in the change I suggested
I finally took the time to properly review the PR. Overall this is a great addition to the book ; my main issue is with what scope we want to have for the book. At the moment, someone who does not know what shear is at all would be confused reading the shear bias page ; should we add an explanation of what it is, in that page or another ? In the same fashion, the word "calibration" is not defined. |
These are very good remarks. I can add some text to the notebook. I'll see what else is there in the book, it's been a while that I have not looked at it :) In any case, the should be some place in the book that explains basic terms such as shear bias, calibration, etc. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
A page on the definition of shear bias. Additive and multiplicative terms, population bias and individual bias.
A notebook to measure shear bias using the Pujol et al. (2017) method. Requires the shear_bias package.