From dab5bb83fb74577feebed2e8fc90a35f655983a9 Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray Date: Wed, 15 Nov 2023 14:46:45 +0300 Subject: [PATCH 1/3] fix: change location of question mark --- .../main/java/ly/count/sdk/java/internal/ModuleFeedback.java | 2 +- .../java/ly/count/sdk/java/internal/ModuleFeedbackTests.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java b/sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java index c990257db..a0ee1da9d 100644 --- a/sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java +++ b/sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java @@ -59,7 +59,7 @@ private void getAvailableFeedbackWidgetsInternal(CallbackOnFinish { + iRGenerator.createImmediateRequestMaker().doWork(params, "/o/sdk?", transport, false, networkingIsEnabled, checkResponse -> { if (checkResponse == null) { L.d("[ModuleFeedback] getAvailableFeedbackWidgetsInternal, Not possible to retrieve widget list. Probably due to lack of connection to the server"); callback.onFinished(null, "Not possible to retrieve widget list. Probably due to lack of connection to the server"); diff --git a/sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java b/sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java index f7ce94b96..b64d50f8e 100644 --- a/sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java +++ b/sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java @@ -197,7 +197,7 @@ public void getAvailableFeedbackWidgets_base(List expecte ImmediateRequestI requestMaker = (requestData, customEndpoint, cp, requestShouldBeDelayed, networkingIsEnabled, callback, log) -> { Map params = TestUtils.parseQueryParams(requestData); Assert.assertEquals("feedback", params.get("method")); - TestUtils.validateRequestMakerRequiredParams("/o/sdk", customEndpoint, requestShouldBeDelayed, networkingIsEnabled); + TestUtils.validateRequestMakerRequiredParams("/o/sdk?", customEndpoint, requestShouldBeDelayed, networkingIsEnabled); TestUtils.validateRequiredParams(params); callback.callback(returnedResponse); }; From 04f6671f7ee384f05ddc6f08847a025691b5eda0 Mon Sep 17 00:00:00 2001 From: Arif Burak Demiray Date: Wed, 15 Nov 2023 14:49:12 +0300 Subject: [PATCH 2/3] fix: feedback widget qmark --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 89ef64aa1..2a77f0189 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 23.10.1 + +* Fixed a bug where getting feedback widgets would not work. + ## 23.10.0 * ! Minor breaking change ! Calling "init" twice will now not reinitialize the SDK. The call will be ignored From 20320c03e0e79f4136a3086f0508b4b107ecacb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Art=C5=ABrs=20Kadi=C4=B7is?= Date: Wed, 15 Nov 2023 14:14:02 +0200 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2a77f0189..365ba8838 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## 23.10.1 -* Fixed a bug where getting feedback widgets would not work. +* Fixed a bug where getting the feedback widget list would fail if "salt" was enabled. ## 23.10.0