Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples #77

Open
8 tasks
izgzhen opened this issue Oct 30, 2018 · 3 comments
Open
8 tasks

Fix examples #77

izgzhen opened this issue Oct 30, 2018 · 3 comments

Comments

@izgzhen
Copy link
Collaborator

izgzhen commented Oct 30, 2018

Currently, there are a lot of examples that failed cozy, which is a regression. See commented ones in test_examples.sh.

  • ztopo-cache
  • nonscalar-tuple
  • sat4j-literal-storage
  • docstring
  • openfire-roster
  • redmine
  • argmin
  • rot1
@Calvin-L
Copy link
Collaborator

What is going wrong in each case?

A few notes about what to expect:

The case study ones (ztopo-cache, openfire-roster, and sat4j-literal-storage) make references to the projects they belong to and therefore must be compiled by their projects' respective build systems, with all the other project files in place. They are in the examples folder as examples, not as tests, and will not work without a lot more infrastructure.

Some of the new ones (nonscalar-tuple and redmine, maybe) use features that have never been supported, like collections inside of other types like tuples or collections. These aren't really regressions, more like examples that exercise not-yet-implemented functionality.

@izgzhen
Copy link
Collaborator Author

izgzhen commented Oct 31, 2018

I see, I think we can have different levels of expectation:

  1. level 1: don't crash cozy
  2. level 2: don't crash compiler
  3. level 3: can be executed
  4. level 4: functionality validated

currently all examples not commented out can reach level 2, and with a proper driver program like MaxBagMain.java, it might reach level 4.

I think we can be super flexible here, but clarifying this in a CI-backed way would be helpful to users.

@izgzhen
Copy link
Collaborator Author

izgzhen commented Oct 31, 2018

What is going wrong in each case?

I will detail the problem of each case in separate issues in coming days

@Calvin-L Calvin-L added the bug label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants