-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with AppleCore #6
Comments
PiTweaks should not override FoodStats when both food tweaks are turned off. See onEntityJoinWorld here. For AppleCore compatibility, make sure to disable both uncapFood and uncapSaturation tweaks in config/pitweaks.cfg and then restart Minecraft. If you are certain the tweaks are disabled and are still seeing this problem, let me know and I will download AppleCore to investigate. |
Ah, alright, didn't check that. I'm the author of AppleCore, just reporting what was said in squeek502/AppleCore#134:
From your source code, it seems like that can't be true, though. |
Detecting AppleCore and using its APIs per the thread you linked looks like definitely the cleanest way to handle this. |
See TheRandomLabs/RandomTweaks@0489814 for a more complete example implementation |
Issued a hotfix (v1.1.1) to work around the crashes by detecting AppleCore and disabling the conflicting code. Since this feature was completely new in PiTweaks, disabling it will not affect anybody who uses both PiTweaks and AppleCore in a modpack. Leaving this open for now, as I need to think some more about how I want to approach mod compat issues like this. |
CplPibald's Tweaks overrides FoodStats, which is incompatible with AppleCore (and any mod that also overrides FoodStats).
Two options to solve this:
See also squeek502/AppleCore#134
The text was updated successfully, but these errors were encountered: