Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with AppleCore #6

Closed
squeek502 opened this issue Mar 15, 2019 · 5 comments
Closed

Incompatibility with AppleCore #6

squeek502 opened this issue Mar 15, 2019 · 5 comments
Assignees

Comments

@squeek502
Copy link

CplPibald's Tweaks overrides FoodStats, which is incompatible with AppleCore (and any mod that also overrides FoodStats).

Two options to solve this:

  • Use the same method suggested here when AppleCore is installed
  • Don't override FoodStats when the config options for that feature are turned off (only a half-fix, as users would have to disable that feature in order to 'solve' the incompatibility).

See also squeek502/AppleCore#134

@squeek502 squeek502 changed the title Incomatibility with AppleCore Incompatibility with AppleCore Mar 15, 2019
@CplPibald
Copy link
Owner

PiTweaks should not override FoodStats when both food tweaks are turned off. See onEntityJoinWorld here. For AppleCore compatibility, make sure to disable both uncapFood and uncapSaturation tweaks in config/pitweaks.cfg and then restart Minecraft.

If you are certain the tweaks are disabled and are still seeing this problem, let me know and I will download AppleCore to investigate.

@squeek502
Copy link
Author

Ah, alright, didn't check that. I'm the author of AppleCore, just reporting what was said in squeek502/AppleCore#134:

I had hoped turning both configs off dealing with Food for CplPibald would fix the issue, however, this doesn't seem to be the case.

From your source code, it seems like that can't be true, though.

@CplPibald
Copy link
Owner

Detecting AppleCore and using its APIs per the thread you linked looks like definitely the cleanest way to handle this.

@CplPibald CplPibald self-assigned this Mar 15, 2019
@squeek502
Copy link
Author

See TheRandomLabs/RandomTweaks@0489814 for a more complete example implementation

@CplPibald
Copy link
Owner

Issued a hotfix (v1.1.1) to work around the crashes by detecting AppleCore and disabling the conflicting code. Since this feature was completely new in PiTweaks, disabling it will not affect anybody who uses both PiTweaks and AppleCore in a modpack.

Leaving this open for now, as I need to think some more about how I want to approach mod compat issues like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants