New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Login Ticket validity) Timestamp is not checked correctly? #35

Open

mvdgeijn opened this issue May 24, 2019 · 1 comment

mvdgeijn commented May 24, 2019 •

edited

Loading

Line 145: if ($this->login_ticket_timestamp >= (time() + 7200)) {

The timestamp is always expired this way. It should be:

if ($this->login_ticket_timestamp <= (time() - 7200)) {

Collaborator

lsthompson commented Dec 22, 2023

@danhunsaker - what do you think here? It seems okay as-is though I'm in-between test machines.

pve2-api-php-client/pve2_api.class.php

Line 146 in 76fabeb

if ($this->login_ticket_timestamp >= (time() + 7200)) {

lsthompson changed the title ~~Timestamp is not check the correct way~~ (Login Ticket validity) Timestamp is not checked correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment