Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SKL dependence #2

Open
bgpeyton opened this issue Feb 28, 2020 · 0 comments
Open

More SKL dependence #2

bgpeyton opened this issue Feb 28, 2020 · 0 comments

Comments

@bgpeyton
Copy link
Member

Previously issue #35 from lml.

While the home-coded ml algorithms have mostly been phased out of default use, there are still a few defaults remaining that use mlqm functions where skl would suffice. A good example is that, generally, at the end of a kernel-ridge regression run the krr.predict function is used, and passed in a Dataset object along with the representations of the prediction set.

E = mlqm.krr.predict(ds,val_reps)

However, this means that mlqm is used to 1) generate the kernel and 2) solve the set of linear equations for the target function. While this function has been tested to be equivalent to skl, it is far more limiting in that different kernels are not supported in mlqm and additional options that skl rolls out will not be supported unless specifically baked into mlqm. So instead, this function should simply wrap skl with optional kwargs rather than doing its job, so as to future-proof the code and automatically gain any additional functionality of skl.

@bgpeyton bgpeyton mentioned this issue May 8, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant