Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEI Deploying Category shows manual only Manual Application recipes #8044

Open
RaymondBlaze opened this issue Mar 19, 2025 · 0 comments · May be fixed by #8045
Open

JEI Deploying Category shows manual only Manual Application recipes #8044

RaymondBlaze opened this issue Mar 19, 2025 · 0 comments · May be fixed by #8045

Comments

@RaymondBlaze
Copy link

Description

As the title stated, AllRecipeTypes#CAN_BE_AUTOMATED checks for the recipe id ending with _manual_only, which worked fine for the implementation in DeployerBlockEntity#getRecipe as it checked the original recipe id, but the fake deploying recipe created for JEI in ManualApplicationRecipe#asDeploying has the new recipe id suffixed with _using_deployer, which makes the the automation check always return true, resulting manual only recipe to show up in in the Deploying Category when it shouldn't.

Solution

Don't add suffix for recipe with id ending with _manual_only, or make the ManualApplicationRecipe#asDeploying return Optional (which is a breaking change, but makes more sense).

RaymondBlaze added a commit to DragonsPlusMinecraft/Create that referenced this issue Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant