You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the title stated, AllRecipeTypes#CAN_BE_AUTOMATED checks for the recipe id ending with _manual_only, which worked fine for the implementation in DeployerBlockEntity#getRecipe as it checked the original recipe id, but the fake deploying recipe created for JEI in ManualApplicationRecipe#asDeploying has the new recipe id suffixed with _using_deployer, which makes the the automation check always return true, resulting manual only recipe to show up in in the Deploying Category when it shouldn't.
Solution
Don't add suffix for recipe with id ending with _manual_only, or make the ManualApplicationRecipe#asDeploying return Optional (which is a breaking change, but makes more sense).
The text was updated successfully, but these errors were encountered:
RaymondBlaze
added a commit
to DragonsPlusMinecraft/Create
that referenced
this issue
Mar 19, 2025
Description
As the title stated,
AllRecipeTypes#CAN_BE_AUTOMATED
checks for the recipe id ending with_manual_only
, which worked fine for the implementation inDeployerBlockEntity#getRecipe
as it checked the original recipe id, but the fake deploying recipe created for JEI inManualApplicationRecipe#asDeploying
has the new recipe id suffixed with_using_deployer
, which makes the the automation check always returntrue
, resulting manual only recipe to show up in in the Deploying Category when it shouldn't.Solution
Don't add suffix for recipe with id ending with
_manual_only
, or make theManualApplicationRecipe#asDeploying
returnOptional
(which is a breaking change, but makes more sense).The text was updated successfully, but these errors were encountered: