Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching is slow #1

Open
CristianCantoro opened this issue Dec 8, 2015 · 0 comments
Open

Caching is slow #1

CristianCantoro opened this issue Dec 8, 2015 · 0 comments

Comments

@CristianCantoro
Copy link
Owner

The caching strategy is dumb.

Requests are cached simply continuously reading and writing the JSON cache file. As the cache gets bigger this process becomes the bottleneck of the script. It is enough to have a cache in the order of tens of MB to slow down the script consistently.

The current caching mechanism is good only for development purposes to avoid making requests to the Wikisource API while developing. For this reason caching is optional and must be explictly activated with the --enable-caching flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant