Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TimeWindowFilter to Fights #7

Open
CrusaderW opened this issue Oct 16, 2019 · 6 comments
Open

add TimeWindowFilter to Fights #7

CrusaderW opened this issue Oct 16, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@CrusaderW
Copy link
Owner

CrusaderW commented Oct 16, 2019

I think it would be nice to have a "time window filter" in the fights section, that allows you to trim the data by datetime. This allows users to zoom in and exclude all data is a different fight.
I would also like to change the current naming of FIGHT to BATTLE. (see #8)
This is what I would do it with:
https://dc-js.github.io/dc.js/examples/focus-dynamic-data.html
https://github.com/dc-js/dc.js/blob/master/web/examples/focus-dynamic-data.html

@CrusaderW CrusaderW added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 16, 2019
@husar
Copy link

husar commented Oct 29, 2019

Hello, maybe i can solve this issue. Can you give me more information about it?

  1. You want to show only this FIGHTS which correspond with selected time?
  2. Is it based on database?

@CrusaderW
Copy link
Owner Author

Well. so in the next minor versions I will update the backend-logic to compose battles from fights and all the data of a battle will be sent to the Frontend. The graph library (dc-js) will then hold all the data and render all graphics due to user selection. This is done through a crossfilter. The new graph shall allow the user to trim the data of the fight to a specific window. The selection of this filter needs to be communicated with the dc-js - crossfilter so all graphs update their data accordingly.
Feel free to drop by on my discord and we can have a chat about it if you have any further questions.

@husar
Copy link

husar commented Oct 30, 2019

Which data will be used in graph? Which data on X-line and which on Y-line? Where we can get this data?

@CrusaderW
Copy link
Owner Author

CrusaderW commented Oct 30, 2019

I would suggest we display a function per player with the DPS mean over the last 5 seconds. The data is queried by the backend from a mongodb and then provided through a get request to the frontend.
I would recommend you try to get the app running by following the instructions in the readme.
The data is already loaded. You just need to add a graph and hook it up to crossfilter, as far as I understand it...

@husar
Copy link

husar commented Nov 2, 2019

OK I'll try to run this project.

@CrusaderW
Copy link
Owner Author

deprecated

@CrusaderW CrusaderW reopened this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants