Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo2docker details to README #44

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Add repo2docker details to README #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
The JupyterHub docker image used for [hub.cryointhecloud.com](https://cryointhecloud.com),
hosted on https://quay.io/repository/cryointhecloud/cryo-hub-image

The image is built with [repo2docker](https://repo2docker.readthedocs.io), which uses
Ubuntu Bionic Beaver (18.04) as the base image. If you'd like to run a test build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that there's a PR open to modify the base image in repo2docker at jupyterhub/repo2docker#909. I'm planning to update this to 22.04 as soon as possible, which would help with the git version and security issues you mentioned in #45.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome news! Should I omit the comment about 18.04 from this README and instead link to the relevant part of the repo2docker docs? Or leave it here and update the text once jupyterhub/repo2docker#909 is merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just leave it for now. That PR has been open since 2020, and I'm not sure if it's any closer to getting merged 😆

locally, please read the [repo2docker Getting Started
doc](https://repo2docker.readthedocs.io/en/latest/getting-started/index.html).

## Updating packages in this repository

You can add or update packages on the cryointhecloud hub by making pull requests to this
Expand Down