Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest patch version of QGIS (3.28.6) #56

Merged
merged 5 commits into from
May 10, 2023

Conversation

MattF-NSIDC
Copy link

@MattF-NSIDC MattF-NSIDC commented May 10, 2023

When opening the latest alpha of QGreenland 3 (currently unzipped at shared/QGreenland/QGreenland_v3.0.0alpha2), we're seeing this error in the currently-installed version of QGIS:

image

@MattF-NSIDC MattF-NSIDC requested a review from weiji14 May 10, 2023 18:12
@MattF-NSIDC
Copy link
Author

/condalock

@github-actions
Copy link

Binder 👈 Test this PR on Binder

@MattF-NSIDC
Copy link
Author

Looks like some work is needed to get a compatible environment.

@MattF-NSIDC
Copy link
Author

/condalock

environment.yml Outdated Show resolved Hide resolved
@MattF-NSIDC
Copy link
Author

/condalock

mfisher87 added 2 commits May 10, 2023 12:59
I feel these pin changes would have made the upgrade to the QGIS dep a
bit easier.
@MattF-NSIDC
Copy link
Author

MattF-NSIDC commented May 10, 2023

I locked the environment myself, since the action seems to be failing to. I installed the same version of conda-lock as the action has, but I used conda instead of pip. I'm not noticing significant environment differences though, except that I have requests 2.29 and the action has 2.30.

@weiji14
Copy link
Member

weiji14 commented May 10, 2023

I'm getting some error with locking the environment.yml file locally. Some error like this:

yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 60, column 1:
    <<<<<<< HEAD:environment.yml
    ^
could not find expected ':'
  in "<unicode string>", line 61, column 1:
    =======
    ^

Let me check what's happening, it could be that something broke too as you mentioned in #57.

@MattF-NSIDC
Copy link
Author

That looks like a git conflict delimiter is in your environment.yml!

@weiji14
Copy link
Member

weiji14 commented May 10, 2023

Ah oops, I reset the file and conda-lock works now (though I'm getting a different hash). Let me check on #57.

@MattF-NSIDC
Copy link
Author

@weiji14 I'm working on a PR to fix that now! I think I figured out the cause.

@MattF-NSIDC
Copy link
Author

/condalock

@weiji14 weiji14 mentioned this pull request May 10, 2023
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locking works again! Thanks @MattF-NSIDC for figuring out the dependency conflicts. Feel free to merge once the tests pass.

@weiji14 weiji14 changed the title Update to latest patch version of QGIS (3.22.6) Update to latest patch version of QGIS (3.28.6) May 10, 2023
@weiji14 weiji14 merged commit 074b678 into CryoInTheCloud:main May 10, 2023
@MattF-NSIDC MattF-NSIDC deleted the update-qgis-patch-version branch May 10, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants