Clone DH output when mixing with room secret

Cryptodog · Nov 18, 2024 · 5b35ff4 · 5b35ff4
1 parent 3d96fb7
commit 5b35ff4
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/js/workers/ecdh.js b/js/workers/ecdh.js
@@ -28,8 +28,7 @@ function genSharedSecret(theirPublicKey, ourPrivateKey, roomSecret) {
         )
     );
     // concat the room secret to the hashed DH output, and hash that to get the final shared secret
-    const mixed = sharedSecret.concat(toWordArray(roomSecret));
-    sharedSecret = CryptoJS.SHA512(mixed);
+    sharedSecret = CryptoJS.SHA512(sharedSecret.clone().concat(toWordArray(roomSecret)));
 
     return {
         message: sharedSecret.words.slice(0, 8),