Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the LangiumDocument is saved, semantic Identity should be cleaned from temporarily deleted elements #27

Open
hpopov opened this issue Aug 11, 2023 · 0 comments
Open

When the LangiumDocument is saved, semantic Identity should be cleaned from temporarily deleted elements #27

hpopov opened this issue Aug 11, 2023 · 0 comments
Milestone
Sprint 5

Comments

@hpopov
Copy link
Contributor

hpopov commented Aug 11, 2023 •
edited
Loading

(since it is not expected cut models will be reinserted after saving the file)

  • Also, try to add handler on exiting the IDE to persist Semantic Model (since IDE is not managing semanitc model updates. At the same time, it doesn't make sence to remove temporarily deleted models, becuase the update won't be handled by LMS subscribers (if IDE is exiting))
@hpopov hpopov added this to the Sprint 5 milestone Aug 11, 2023
hpopov added a commit that referenced this issue Sep 15, 2023
@hpopov
#27 Invoke artificial identity reconciliation to remove identities ma…
86d5711 
…rked for deletion
hpopov added a commit that referenced this issue Sep 18, 2023
@hpopov
Refactor #27 and implement #29
7944b71 
- Semantic Identity is cleaned from temporarily deleted elements and Save action is sent to rootModel subscribers
- Updates combination and throttling of Source Model update pushing is moved to Subscriptions (from lms-document-builder)
- Edge case is covered to prevent unnesessary updates from being sent to new subscriber (when new subscription is added while there are some model updates accumulated already, which should not be propagated). The data structure should be optimized though
@hpopov hpopov mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 5
Development

No branches or pull requests
1 participant
@hpopov