Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rootModelId easily accessible (from document or SemanticDomain) #30

Open
hpopov opened this issue Sep 18, 2023 · 0 comments
Open

Make rootModelId easily accessible (from document or SemanticDomain) #30

hpopov opened this issue Sep 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@hpopov
Copy link
Contributor

hpopov commented Sep 18, 2023

At the moment, across the codebase there are several ad-hoc solutions for rootModelId retrieval from abstract semantic domain, or LangiumDocument. ModelUpdateCalculators even has rootModelId as a parameter to its factory method getOrCreateCalculator just because it is easier to supply rootModelId this way, then to fetch it intricately from the LmsDocument.

Need to make this access easy and standartized to remove this code smell.
@hpopov hpopov mentioned this issue Sep 20, 2023
Open
@hpopov hpopov added the enhancement New feature or request label Sep 20, 2023
hpopov added a commit that referenced this issue Sep 20, 2023
@hpopov
#30 Add rootId API to SemanticDomain
52d3211
hpopov added a commit that referenced this issue Sep 20, 2023
@hpopov
#30 Get rid of hardcoded rootModelIds
e19fff3 
IdentifiedRoot is eliminated as not needed
@hpopov hpopov mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hpopov