Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delay between receiving an LMS Update API request and pushing an update to subscription #36

Open
hpopov opened this issue Oct 5, 2023 · 0 comments
Open

Remove delay between receiving an LMS Update API request and pushing an update to subscription #36

hpopov opened this issue Oct 5, 2023 · 0 comments

Comments

@hpopov
Copy link
Contributor

hpopov commented Oct 5, 2023

Currently, when an update request is received, the TextEdit is computed and applied to an open WorkspaceDocument through an LSP client. The changes are subsequently propagated to LSP server, and go through all DocumentBuilder steps (including model reconciliation, changes computation and pushing an update). When the calculated updates are pushed through LMSDocumentBuilder, there are a 300ms delay designed to accumulate also subsequent changes (given the document is modified manually by the user) to not clog the subscription channel with too many update messages.
However, this delay should be disregarded, when an update comes from LMS Update API, since there will be no immediate text edits following.
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Return WorkspaceEdit with no changes property if no changes
ad24ed5
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Apply all the changes to calculated updates
6fdf51d 
So that they are calculated correctly for LMS Update API changes (e.g., name update)
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Unify task/transition comparison and extract to base function
a0f5b23
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Ensure Model properties are only compared with previous semantic …
0ca1b04 
…model

If previous is Identity, then it is === to current.identity, which means it will never assign properties to Update, since theier values will always be identical
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Remove individual rename updates pushing
ec3917d 
In favor of global updates pushing
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Remove individual rename updates pushing
8f481b2 
In favor of global updates pushing
hpopov added a commit that referenced this issue Oct 5, 2023
@hpopov
#36 Add hasImmediateChanges flag to LmsDocument to push Updates wit…
a16dbb5 
…hout delay when modifying source from LMS Update API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hpopov