-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LMS API endpoint for Model validation #37
Comments
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
…he default Langium implementation This is needed to customize acceptor
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
1. Transition extends ArtificialAstNode 2. Validated 3. sem.Validated (dependent nodes are identified) 4. IdentifiedTransition (Transition itself is identified)
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
So that they also take part in LMS Model Validation API endpoint
hpopov
added a commit
that referenced
this issue
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DefaultDocumentValidator
to customizeacceptor
creation in methodvalidateAst
.acceptor
should not just accumulateDiagnostic
(and later attach it toLangiumDocument
), but also add validation info (including messages and, most importantly, AstNodes) toSemantic Domain
provided that consumedAstNode
is semantically Validname
from theTransition
-- it is relevant forTransitionIdentity
only, it is not used in Transition LMS Model! It will pose some difference in Reconciler (which is OK), but at the same time, Valid Transitions (ArtificialAstNodes) will be available at the same time as Valid Tasksacceptor
can check, if the Valid node is present (or, is the node Valid?), so that validation checks, which do semantic validation only (invalid nodes are not part of LMS model), are ignoredThe text was updated successfully, but these errors were encountered: