Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for [ru-ru] #52

Closed
Teppy381 opened this issue Aug 7, 2024 · 3 comments · Fixed by #53
Closed

Localization for [ru-ru] #52

Teppy381 opened this issue Aug 7, 2024 · 3 comments · Fixed by #53
Assignees
Labels
localization Add or fix translations

Comments

@Teppy381
Copy link
Contributor

Teppy381 commented Aug 7, 2024

Language

Russian

Current translation

{
  "enchantment.minecraft.soul_fire_aspect": "Заговор души",
  "enchantment.minecraft.soul_flame": "Воспламенение души",
  "enchantment.minecraft.soul_fire_aspect.desc": "Поджигает душу цели и наносит ей дополнительный урон.",
  "enchantment.minecraft.soul_flame.desc": "Выпущенные стрелы поджигают душу цели и наносят ей дополнительный урон."
}

Proposed translation

{
  "enchantment.minecraft.soul_fire_aspect": "Заговор огня душ",
  "enchantment.minecraft.soul_flame": "Воспламенение душ",
  "enchantment.minecraft.soul_fire_aspect.desc": "Поджигает цель огнем душ.",
  "enchantment.minecraft.soul_flame.desc": "Стрелы выпущенные из лука, наносят дополнительный урон огнем душ."
}

Reason

More consistent with translation of vanilla enchantments

@Crystal-Spider
Copy link
Member

Crystal-Spider commented Aug 7, 2024

Could you please open a PR instead of just an issue?

@Crystal-Spider Crystal-Spider moved this from To Vet to Todo in soul-fire-d management Aug 7, 2024
@Crystal-Spider Crystal-Spider added enhancement New feature or request high priority Needs to be worked on ASAP labels Aug 7, 2024
@Crystal-Spider Crystal-Spider linked a pull request Aug 8, 2024 that will close this issue
1 task
@Crystal-Spider Crystal-Spider moved this from Todo to In Progress in soul-fire-d management Aug 8, 2024
@Crystal-Spider Crystal-Spider moved this from In Progress to Pending in soul-fire-d management Aug 8, 2024
@Crystal-Spider Crystal-Spider added the pending Waiting for something label Aug 8, 2024
@Crystal-Spider
Copy link
Member

Waiting to merge PR #53

@Crystal-Spider Crystal-Spider removed the pending Waiting for something label Aug 25, 2024
@Crystal-Spider Crystal-Spider moved this from Pending to In Progress in soul-fire-d management Aug 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in soul-fire-d management Aug 31, 2024
@Crystal-Spider Crystal-Spider added localization Add or fix translations and removed high priority Needs to be worked on ASAP enhancement New feature or request labels Aug 31, 2024
@Crystal-Spider
Copy link
Member

By tomorrow we are going to release a new version for all supported Minecraft versions with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Add or fix translations
Projects
Development

Successfully merging a pull request may close this issue.

2 participants