Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Abnormals Mod Support (Endergetic Expansion) (Caverns and Chasms) #64

Open
1 task done
SirYawns opened this issue Jan 24, 2025 · 8 comments
Open
1 task done
Assignees
Labels
medium priority Needs to be worked on other mod Not compatible with other mod, needs work from them pending Waiting for something

Comments

@SirYawns
Copy link

SirYawns commented Jan 24, 2025

I have confirmed no other issue asks the same question

  • I have searched for existing issues

Question

Team Abnormals has added 2 new fire types to the game within their two mods Endergetic Expansion (Ender Fires) and Caverns and Chasms (Cupric Fires)
I would love to see support for these mods!

@SirYawns SirYawns added medium priority Needs to be worked on question Further information is requested labels Jan 24, 2025
@Crystal-Spider
Copy link
Member

You should really open an issue on their side, because this mod provides and API for other mods to add support themselves (for example, see BYG or Infernal Expansion, or any mod in the compatibility list).

If you do open the issue(s), please tag me.
I will then also open a PR to implement the change.

@Crystal-Spider Crystal-Spider added other mod Not compatible with other mod, needs work from them pending Waiting for something and removed question Further information is requested labels Jan 24, 2025
@Crystal-Spider Crystal-Spider moved this from To Vet to Pending in soul-fire-d management Jan 24, 2025
@Crystal-Spider
Copy link
Member

Crystal-Spider commented Jan 24, 2025

I checked it out, and it seems that for Caverns and Chasms there is already an open issue (but unfortunately they didn't tag me so I didn't know until now).
So it's enough for you to open an issue for Endergetic Expansion (and tag me please).

@SirYawns
Copy link
Author

I was unsure if Team Abnormals would be willing to add support for other mods like this or generally listen to community feedback. If you could add it on the side of this mod and its simple enough that would be wonderful! If not its fine. Thank you!

@Crystal-Spider
Copy link
Member

I understand, but I still prefer to try the other way first.
If, after you open an issue and I open a PR to fix the issue, they still don't seem to respond, I can consider adding compatibility from my side.

@SirYawns
Copy link
Author

SirYawns commented Jan 24, 2025

Sounds good. Do you want me to open an issue about endergetic specifically?

@Crystal-Spider
Copy link
Member

Yes, please. It might motivate them more if it's a user asking for compatibility rather than the mod author.

@rafaelkai
Copy link

rafaelkai commented Jan 26, 2025

Team abnormals doesn't usually add support for another mods and rather prefer to be the other way around. Second the support for abnormals fire directly in Soul fire'd.

@Crystal-Spider
Copy link
Member

Team abnormals doesn't usually add support for another mods and rather prefer to be the other way around. Second the support for abnormals fire directly in Soul fire'd.

No. This is not how things work. Soul Fire'd main purpose is to provide an API for other mods. Not unlike GeckoLib or many others.
For this reason, it's up to other mods to implement compatibility, as many have done already.
What I can do is make this as easy as possible for other mod authors, for instance by creating PRs with all the required changes and improvements for their mods (e.g., see BYG and Infernal Expansion), along with life-long support.
And all of this is already much more than many others do.

Anyway, for C&C I have a PR almost ready. For EE it might take some time since I'm in the middle of my university exams.
Also, I'm still waiting for an issue to be opened on EE side asking for compatibility with SF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Needs to be worked on other mod Not compatible with other mod, needs work from them pending Waiting for something
Projects
Status: Pending
Development

No branches or pull requests

3 participants