Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameProviderDispatcher for Godot should start earlier #286

Closed
orcharddweller opened this issue Jan 6, 2025 · 1 comment
Closed

FrameProviderDispatcher for Godot should start earlier #286

orcharddweller opened this issue Jan 6, 2025 · 1 comment

Comments

@orcharddweller
Copy link

Hey, amazing library!

Is there any reason that FrameProviderDispatcher starts on _Ready not _EnterTree?

As it is an autoload it should work fine either way, and using _EnterTree instead means R3 is available on _EnterTree for other singletons and nodes in the scene.

I'm happy to submit a PR if this is ok.

@neuecc
Copy link
Member

neuecc commented Jan 8, 2025

Thank you.
The optimal placement would be where it's first called from the engine.
It seems EnterTree is called before Ready - I see, EnterTree would be more appropriate!
Is there anything called before this? If not, let's go with EnterTree.

@neuecc neuecc closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants