Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing DAO Contract Address Issue #24

Open
0xjame5 opened this issue Apr 15, 2022 · 3 comments
Open

Fix missing DAO Contract Address Issue #24

0xjame5 opened this issue Apr 15, 2022 · 3 comments

Comments

@0xjame5
Copy link
Contributor

0xjame5 commented Apr 15, 2022

Problem:
given an indexer handle matches a contract type, but the underlying logic used to parse the contract fail we fail close.

Solution:
Instead fail open on missing a DAO Contract address. This means that given a pluggable indexer's handle run fails then we fail open.

@0xjame5
Copy link
Contributor Author

0xjame5 commented Apr 15, 2022

indexer_1         | thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: no dao_address', /app/src/historical_parser.rs:85:69
indexer_1         | stack backtrace:
indexer_1         |    0:     0x560c95bf92ad - std::backtrace_rs::backtrace::libunwind::trace::hee598835bc88d35b
indexer_1         |                                at /r

@gavindoughtie
Copy link
Contributor

I might have fixed this with my latest commit; want to try?

@0xjame5
Copy link
Contributor Author

0xjame5 commented Apr 21, 2022

Yep this is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants