Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling Actions Together #461

Open
elijahbenizzy opened this issue Dec 5, 2024 · 0 comments
Open

Bundling Actions Together #461

elijahbenizzy opened this issue Dec 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@elijahbenizzy
Copy link
Contributor

Is your feature request related to a problem? Please describe.

@gamarin2 asks:

Hey! While working with class-based actions, I ended up creating state transitions that must logically be split in two separate actions, but where the second one must always be preceded by the first one.

In my case, it's a FormatSummarizer action that formats messages before transitioning to a Summarizer action. These two actions form what I would call an "action bundle": the second one can't be separated from the first one. For now, I have documented that requirement in my class docstring, but it would be nice to have it more strictly enforced. 

I'm sure there are various ways we could achieve this, but perhaps the easiest would be to add a property to the action class where you could specify preceding/following action classes. The AppBuilder would then fail to build if you haven't added the proper transitions.

@mdrideout also suggests:

I would say that I have a very large number of use cases for this, and creating an entire sub-graph for it is painful.

To piggyback on this, I also have a very large number of use cases for running actions with high concurrency, and have been creating sub-graphs simply for the purpose of running a single action for ~10 items. 
but I may be doing this as a workaround because I had a some issues trying to use MappedStates (?) with either pydantic or async.

Describe the solution you'd like
A way to have an action represent a graph.

class MultiAction:
    @abc.abstractmethod
    def get_graph() -> Graph:
        ...

class ActionChain(MultiAction):
    @abc.abstractmethod
    def get_actions() -> List[[Tuple[str, Union[Action, Callable]]]:
        ...

    def get_graph() -> Graph:
        named_actions = self.get_actions()
        action_names = [name for name, _ in named_actions]
        return GraphBuilder().with_actions(**dict(actions)).with_transitions(zip(action_name, action_names[1:]))

Describe alternatives you've considered
Could also have with_subgraph in builder, similar thing. This allows for packaging at the action level for reusability. Might also want the ability to remap inputs/outputs:

def state_maps() -> Tuple[dict, dict]:
    ....

Additional context
Add any other context or screenshots about the feature request here.

@elijahbenizzy elijahbenizzy added the enhancement New feature or request label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant