Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple target parameters for pipe_input #1177

Open
jernejfrank opened this issue Oct 12, 2024 · 1 comment
Open

multiple target parameters for pipe_input #1177

jernejfrank opened this issue Oct 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jernejfrank
Copy link
Contributor

It makes sense that pipe_input doesn't restrict to the first parameters #1161 and #1173 address this.

Is your feature request related to a problem? Please describe.
Sometimes it would be good to have the flexibility to target multiple parameters with different transforms on a local level like mutate/pipe_output do.

Describe the solution you'd like
Something like step.on_input("target_param")

Describe alternatives you've considered
Using pipe_output on th eprevious node instead of pipe_input. Stacking multiple pipe_input decorators.

Additional context
The scaffolding for this functionality is already implemented, but is disabled / needs to be tested.

@elijahbenizzy
Copy link
Collaborator

To enable this, look at the files in this PR: https://github.com/DAGWorks-Inc/hamilton/pull/1173/files

(a) the commented out tests
(b) A few commented out code-blocks

We've decided to leave this out to reduce surface area, but it should be easy enough to turn on!

@zilto zilto added the enhancement New feature or request label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants