Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1058 Use support email in the system email message 'closing' text #176

Conversation

PaulBoon
Copy link

@PaulBoon PaulBoon commented Sep 5, 2023

What this PR does / why we need it:
This PR fixes a problem =with the 'system emails', the end of thos emails refer to a contact email, but instaed of using that ione, the system email address is being used.

Which issue(s) this PR closes:
Jira issue: https://drivenbydata.atlassian.net/browse/DD-1058

Special notes for your reviewer:

Suggestions on how to test this:

  • Checkout and build this PR for instance in the dd-dtap/shared-code directory.
  • Start the archaeoloy base box; start-preprovisioned-box.py -s dev_archaeology dev_vocabs.
  • Upgrade to 5.14; deploy.py --playbook provisioning/patches/upgrade-dataverse/to-5.14.yml dev_archaeology .
  • Set the jvm option; vagrant ssh dev_archaeology and then /usr/local/payara5/glassfish/bin/asadmin -Dcreate-jvm-options [email protected] and restart payara; sudo systemctl restart payara..
  • In dd-dtap, deploy the'fixed' war file; deploy.py --dataverse-war shared-code/dataverse/target/dataverse-5.14 dev_archaeology.
  • Browse to the password reset page; https://dev.archaeology.datastations.nl/passwordreset.xhtml and request a reset for a test user account, for instance [email protected].
  • On the vagrant box, check if the mail is sent with curl http://0.0.0.0:1080/messages | jq.
[
  {
    "id": 2,
    "sender": "<[email protected]>",
    "recipients": [
      "<[email protected]>"
    ],
    "subject": "Dataverse Password Reset Requested",
    "size": "852",
    "created_at": "2023-09-05T11:49:53+00:00"
  }
]
  • Use the id to read the mail text; curl http://0.0.0.0:1080/messages/2.plain if the id = 2.
Hi Testing  Testing,

Someone, hopefully you, requested a password reset for testing.

Please click the link below to reset your Dataverse account password:

 https://dev.archaeology.datastations.nl/passwordreset.xhtml?token=8320bc66-7045-4339-ab0f-7ac6268ec7d8 

 The link above will only work for the next 60 minutes.

 Please contact us if you did not request this password reset or need further help.

You may contact us for support at [email protected].

Thank you,
DANS Data Station Archaeology (dev) Support

Important to check is that the 'sender' is still the system email; [email protected], but the mail text should give that support email address ([email protected]) to contact us!

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@PaulBoon PaulBoon marked this pull request as ready for review September 5, 2023 12:55
@janvanmansum janvanmansum merged commit 72840e2 into DANS-KNAW:v5.14-DANS-DataStation Sep 26, 2023
@PaulBoon
Copy link
Author

Just created an issue at IQSS: IQSS#10287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants