Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1783: blocked page because of not found host dataverse #212

Open
wants to merge 2 commits into
base: v6.5-DANS-DataStation
Choose a base branch
from

Conversation

jo-pol
Copy link

@jo-pol jo-pol commented Mar 10, 2025

What this PR does / why we need it:

A dataset is not saved and there is no option to correct the mistake if you edit the “Host Dataverse” field and immediately correct and leave it. When clicking Save the page freezes and after a hard refresh all your metadata is gone and you have to start over. Reproduced in 6.3 and 6.5 (DANS branches).

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Not sure about the impact when templates are used. See IQSS#11301 (comment)

Suggestions on how to test this:

  1. In the user interface click Add Data → New Dataset
  2. The cursor is placed in the “Host Dataverse” field.
  3. Type a space, remove it and quickly put the cursor in the title field.
  4. Fill in the required fields and click Save.

Not tested with templates.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@DANS-KNAW/core-systems

@coveralls
Copy link

Pull Request Test Coverage Report for Build #147

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 22.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/DataverseConverter.java 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/harvard/iq/dataverse/actionlogging/ActionLogRecord.java 1 80.88%
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/ezid/EZIdDOIProvider.java 2 6.12%
Totals Coverage Status
Change from base Build #141: 0.0%
Covered Lines: 19542
Relevant Lines: 86712

💛 - Coveralls

@jo-pol jo-pol changed the title Dd 1783 blocked page DD-1783: blocked page because of not found host dataverse Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants