-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mach number has no effect on calculations #5
Comments
I confirm that the current version, doesn't correctly set Mach number and using xf.M, will only compute Sonic Cp and Q/Qinf, and have no effect on Cl,Cd,Cm. Also I should note that the code will throw an error if you try to set mach number before loading airfoil in python. And yet another minor but annoying issue is the way the range of angles of attack is defined: it excludes the value of last angle of attack "a_end". Cheers! |
Regarding the ‘annoying issue’: This is modelled after the original behaviour of Python's range() function, which also does not include the endpoint. But I can see the annoyance of such a behaviour. I approached it with those two changes (please note, that his has been moved to the new codeberg repository, and the corresponding issue):
|
Hello,
I've correctly installed your module but when I attempt to set a Mach Number, it doesn't have any effect on the calculations. The coefficients stay the same.
Here's a plot with the generated polars of a NACA 0012 with different Mach numbers.
And this is the code I used:
The text was updated successfully, but these errors were encountered: