Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: ethernet hostname not set #313

Open
prchal opened this issue Feb 23, 2023 · 1 comment
Open

Bug Report: ethernet hostname not set #313

prchal opened this issue Feb 23, 2023 · 1 comment
Labels
Bug Something isn't working as designed EX-CommandStation Item relates to the core EX-CommandStation code

Comments

@prchal
Copy link

prchal commented Feb 23, 2023

Version

4.2.18

Bug description

This version don't set hostname from config.h when ethernet is enabled. It sends to DHCP "WIZnet161208" which is probably default.

Steps to reproduce the bug

  1. connect W5500
  2. #define ENABLE_ETHERNET true
  3. #define WIFI_HOSTNAME "DCCEX"
  4. turn on
  5. wait for dhcp lease

Expected behaviour

Should set hostname defined in config.h.
Previous version 4.1.* did it.

Screenshots

No response

Hardware in use

mega2560, W5500

Additional context

No response

@prchal prchal added the Bug Something isn't working as designed label Feb 23, 2023
@github-actions github-actions bot added the EX-CommandStation Item relates to the core EX-CommandStation code label Feb 23, 2023
@dcc-ex-project-workflow-app dcc-ex-project-workflow-app bot moved this to To Do in DCC-EX Feb 23, 2023
@habazut
Copy link
Contributor

habazut commented Mar 27, 2023

Om Ethernet (not Wifi) the hostname presented in the DHCP request is set by the Ethernet library and I do not see any way to override that. See #define HOST_NAME line 45 of libraries/Ethernet/src/Dhcp.h and line 191 of Dhcp.cpp. To change that, the ethernet library has to be changed.

Or do you want that the Withrottle service is announced with mDNS? In that case someone has to implement that for Ethernet (s in "find library and integrate the code").

Regards,
Harald.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed EX-CommandStation Item relates to the core EX-CommandStation code
Projects
Status: To Do
Development

No branches or pull requests

2 participants