Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusty-x86: Unicorn engine tests are flaky #26

Open
DCNick3 opened this issue Apr 15, 2023 · 0 comments
Open

rusty-x86: Unicorn engine tests are flaky #26

DCNick3 opened this issue Apr 15, 2023 · 0 comments

Comments

@DCNick3
Copy link
Owner

DCNick3 commented Apr 15, 2023

These problems have risen after migration from unicorn to unicorn-engine crate, which itself was prompted by ABI-breaking update of 2.0.1 of unicorn itself:

I think there is some thread synchronization issue in the unicorn-engine (or LLVM, which was also updated!), as some tests are non-deterministically failing with multiple threads but are fine in single-threaded context.

Then there is a problem of the pushfd_pop_eax test, which simply does

pushf
pop eax

The mismatch is that rusty-x86 has EAX be 0, while unicorn has it be 2. This result is stable, but I don't think it's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant