Change the way a too many login attempts message is asserted against (#…

…21) * Change the way a too many login attempts message is asserted against * Removed unused import
DCzajkowski · Jul 12, 2019 · 99f00b6 · 99f00b6
1 parent 60b0a97
commit 99f00b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Console/stubs/tests/Feature/Auth/EmailVerificationTest.php b/src/Console/stubs/tests/Feature/Auth/EmailVerificationTest.php
@@ -5,7 +5,6 @@
 use App\User;
 use Tests\TestCase;
 use Illuminate\Support\Facades\URL;
-use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Notification;
 use Illuminate\Auth\Notifications\VerifyEmail;
 use Illuminate\Foundation\Testing\RefreshDatabase;

diff --git a/src/Console/stubs/tests/Feature/Auth/LoginTest.php b/src/Console/stubs/tests/Feature/Auth/LoginTest.php
@@ -42,6 +42,11 @@ protected function guestMiddlewareRoute()
         return route('home');
     }
 
+    protected function getTooManyLoginAttemptsMessage()
+    {
+        return sprintf('/^%s$/', str_replace('\:seconds', '\d+', preg_quote(__('auth.throttle'), '/')));
+    }
+
     public function testUserCanViewALoginForm()
     {
         $response = $this->get($this->loginGetRoute());
@@ -163,9 +168,10 @@ public function testUserCannotMakeMoreThanFiveAttemptsInOneMinute()
 
         $response->assertRedirect($this->loginGetRoute());
         $response->assertSessionHasErrors('email');
-        $this->assertContains(
-            'Too many login attempts.',
-            collect($response
+        $this->assertRegExp(
+            $this->getTooManyLoginAttemptsMessage(),
+            collect(
+                $response
                 ->baseResponse
                 ->getSession()
                 ->get('errors')