Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Container] add field 'UseDocker' to ContainerConfig #52

Closed
wants to merge 1 commit into from
Closed

[Container] add field 'UseDocker' to ContainerConfig #52

wants to merge 1 commit into from

Conversation

zeroFruit
Copy link
Member

@zeroFruit zeroFruit commented Oct 15, 2018 •
edited
Loading

rel issue: #50

Add UseDocker field to config

if UseDocker field set, use deploy it-chain node to docker
else deploy it-chain node to host machine

@zeroFruit zeroFruit changed the title add field 'UseDocker' to ContainerConfig [Container] add field 'UseDocker' to ContainerConfig Oct 15, 2018
@hea9549
Copy link
Member

hea9549 commented Oct 15, 2018

컨테이너 단위가아니라
테서렉트 자체에서 받으려고합니다!
노드 자체가 (테서렉트) 도커모드인지 중요할 것 같아서요~!
컨테이너 자체는 항상 도커니까 테서렉트가 받는게 좋을 것 같아용

@zeroFruit
Copy link
Member Author

zeroFruit commented Oct 15, 2018 •
edited
Loading

앗 그렇네요! 혹시 작업중이신가요? @hea9549

@zeroFruit
Copy link
Member Author

아 생각해보니 이부분은 ivm에서 해야할 부분인 것 같네요.. 닫겠습니다

@zeroFruit zeroFruit closed this Oct 16, 2018
@zeroFruit zeroFruit mentioned this pull request Oct 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junbeomlee junbeomlee Awaiting requested review from junbeomlee

@hea9549 hea9549 Awaiting requested review from hea9549

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroFruit @hea9549