Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in Attribute Definitions #14

Open
2 of 3 tasks
asteriskayush007 opened this issue Jan 29, 2025 · 0 comments
Open
2 of 3 tasks

Ambiguity in Attribute Definitions #14

asteriskayush007 opened this issue Jan 29, 2025 · 0 comments

Comments

@asteriskayush007
Copy link
Member

Issue: Ambiguity in Attribute Definitions

Description:

The attr_dict defines several models like interface_gan, stylespace, and sefa with attributes that may cause confusion:

  • interface_gan: The strength values for upper_length and bottom_length are unclear in terms of how negative/positive values affect them.
  • stylespace: The list of three elements for upper_length and bottom_length (layer, strength, threshold) may not be intuitive.
  • sefa: The nested list structure for layers and strength is ambiguous, especially regarding the strength value's impact.

Motivation:

Improve clarity and consistency in how the dictionary attributes are structured and interpreted. Proper documentation will help prevent misinterpretation and errors.

Suggested Improvements:

  • Clarify how strength values work (positive/negative) for each model.
  • Ensure consistent structure or clearly define differences across models.

Checklist:

  • Review attribute structure.
  • Add documentation on attribute usage.
  • Test for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant