New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numeric exclusiveMinimum and exclusiveMaximum for 3.1 #24

Open

1 of 2 tasks

charjr opened this issue Nov 7, 2024 · 0 comments

Open

1 of 2 tasks

Support numeric exclusiveMinimum and exclusiveMaximum for 3.1 #24

charjr opened this issue Nov 7, 2024 · 0 comments

charjr commented Nov 7, 2024 •

edited

Loading

OpenAPI 3.1 follows the Json Schema from 2020:
exclusiveMaximum MUST be a number
exclusiveMinimum MUST be a number

To truly support the keywords there are 2 changes required:

Allow for numeric values to be passed to exclusiveMaximum and exclusiveMinimum Support OpenAPI 3.1. ExclusiveMinimum and ExclusiveMaximum #23

Do not use a boolean default if the OpenAPI is 3.1

cebe-php-openapi/src/spec/Schema.php

Lines 131 to 132 in 9ae960c

    
           'exclusiveMinimum' => $this->hasPropertyValue('minimum') ? false : null, 
        
           'exclusiveMaximum' => $this->hasPropertyValue('maximum') ? false : null,

I am not sure how to go about providing a conditional default, that seems like a tricky task.

charjr mentioned this issue

Support OpenAPI 3.1. ExclusiveMinimum and ExclusiveMaximum #23

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment