Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EYQB-718 avoid deprecated terraform arguments #470

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

RobertGHippo
Copy link
Collaborator

@RobertGHippo RobertGHippo commented Nov 22, 2024

Description

While investigating SSL certificate auto-renewal and rotation, it might be appropriate to address our use of deprecated terraform arguments. This also probably requires a migration to a later version of terraform, which we should possibly do too as part of this.

Ticket number

EYQB-718

How Has This Been Tested?

Run terraform plan in GitHub.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RobertGHippo RobertGHippo changed the title Avoid deprecated terraform arguments EYQB-718 avoid deprecated terraform arguments Nov 22, 2024
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98%
Dfe.EarlyYearsQualification.Content 98% 90%
Dfe.EarlyYearsQualification.Web 96% 90%
Summary 97% (4120 / 4228) 91% (678 / 746)

Minimum allowed line rate is 90%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant