Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gcp wif in preproduction env #427

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Enable gcp wif in preproduction env #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion terraform/aks/config/preproduction.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,7 @@
"preproduction.check-the-childrens-barred-list.education.gov.uk"
],
"azure_enable_backup_storage": false,
"enable_logit": true
"enable_logit": true,
"enable_dfe_analytics_federated_auth": true,
"gcp_dataset_name": "ccbl_events_preprod"
}
2 changes: 1 addition & 1 deletion terraform/aks/dfe_analytics.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ module "dfe_analytics" {
namespace = var.namespace
service_short = var.service_short
environment = local.app_name_suffix
gcp_dataset = "ccbl_events_${var.config}"
gcp_dataset = var.gcp_dataset_name != null ? var.gcp_dataset_name : "ccbl_events_${var.config}"
}
6 changes: 6 additions & 0 deletions terraform/aks/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ variable "config" {
description = "Long name of the environment configuration, e.g. development, staging, production..."
}

variable "gcp_dataset_name" {
description = "Name of the GCP dataset used by Bigquery for an environment. If null will use ccbl_events_{var.config} "
type = string
default = null
}

locals {
service_name = "check-childrens-barred-list"
version = "1.9.7"
Expand Down