Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdraw draft applications for expired jobs #7048

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

starswan
Copy link
Contributor

@starswan starswan commented Sep 6, 2024

Trello card URL

https://trello.com/c/DJ45aezT/1194-draft-job-application-management

Changes in this PR:

Added background job to withdraw any draft applications with expired vacancies

Next steps:

  • Terraform deployment required?

  • New development configuration to be shared?

@starswan starswan force-pushed the withdraw-draft-applications-for-expired-jobs branch from cbaf6f1 to 2eca021 Compare September 9, 2024 07:34
@starswan starswan marked this pull request as ready for review September 9, 2024 09:12
scruti
scruti previously approved these changes Sep 11, 2024
Copy link
Collaborator

@scruti scruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Sep 12, 2024

Review app deployed to https://teaching-vacancies-review-pr-7048.test.teacherservices.cloud on AKS

@starswan starswan force-pushed the withdraw-draft-applications-for-expired-jobs branch from ab9a93b to 7ebd28c Compare September 19, 2024 08:34
@KyleMacPherson KyleMacPherson deleted the withdraw-draft-applications-for-expired-jobs branch September 25, 2024 08:20
@KyleMacPherson KyleMacPherson restored the withdraw-draft-applications-for-expired-jobs branch September 25, 2024 08:27
@starswan starswan removed the deploy label Sep 26, 2024
@starswan starswan marked this pull request as draft September 26, 2024 07:46
@starswan
Copy link
Contributor Author

starswan commented Oct 7, 2024

Changed implementation to delete ancient draft applications for expired vacancies

@starswan starswan closed this Oct 7, 2024
@starswan starswan reopened this Nov 7, 2024
@starswan starswan force-pushed the withdraw-draft-applications-for-expired-jobs branch from 7ebd28c to 6ba12dc Compare November 7, 2024 14:37
@starswan starswan marked this pull request as ready for review November 7, 2024 14:37
@starswan starswan requested a review from scruti November 7, 2024 14:38
@starswan starswan dismissed scruti’s stale review November 7, 2024 14:57

implementation completely changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants