Add new campaign bespoke landing page #7137

ddippolito · 2024-10-03T10:44:59Z

Trello card URL

https://trello.com/c/kqe2MWBV/1253-create-bespoke-landing-pages-for-new-teachers-digital-activity

Changes in this PR:

We're adding a new campaign bespoke landing page. Users will be able to access this temporary landing page through links in QR codes within physical booklets or through emails. The page has a different design from the orginal job search page but we can re-use some of the components.

Screenshots of UI changes:

github-actions · 2024-10-03T13:49:33Z

Review app deployed to https://teaching-vacancies-review-pr-7137.test.teacherservices.cloud on AKS

starswan · 2024-10-07T15:38:01Z

app/views/vacancies/campaign_landing_page.html.slim

+      .custom-banner
+        .govuk-grid-row
+          .govuk-grid-column-one-third-at-desktop
+            h1.govuk-heading-l class="govuk-!-margin-bottom-4" = "#{@jobseeker_name}, find your primary teacher job"


It looks like we've only implemented the 'primary teacher' landing page here. Do we not need to parameterise this so we can do secondary teachers (and others) - using education_phase or something similar?

It's a good question, and I've asked it to @EllieNodder myself. This is not technically a landing page but a campaign page.
This is a throwaway campaign page that will run for a certain amount of time, and we can remove it afterwards.

As a broader context, we need to rework the way landing pages are generated, as we need them to be more customisable.

yes, could we make it so it pulls through either 'primary' or 'secondary', depending on their info in Mailchimp?

starswan · 2024-10-07T15:41:03Z

app/controllers/vacancies_controller.rb

+      working_patterns << "full_time" if campaign_params.delete(:email_fulltime) == "true"
+      working_patterns << "part_time" if campaign_params.delete(:email_parttime) == "true"
+      working_patterns << "job_share" if campaign_params.delete(:email_jobshare) == "true"


should we not use ActiveModel::Type::Boolean.new.cast(value) here so that we cope with values of "1" (and Yes?) as well as (lowercase) true?

Nice! Thanks

starswan · 2024-10-07T15:42:20Z

app/controllers/vacancies_controller.rb

+                  :email_phase, :email_ECT, :email_fulltime, :email_parttime, :email_jobshare, :email_contact)
+          .tap do |campaign_params|
+      campaign_params[:location] = campaign_params.delete(:email_location)
+      campaign_params[:radius] = campaign_params.delete(:email_radius)


I think we are supposed to pre-select 15 mile radius if it isn't specified (which it probably won't be?) - or is that going to be done by the email rather than here?

Yeah, the radius is set in the email link. But good observation!

starswan · 2024-10-07T15:45:17Z

spec/system/jobseekers/jobseekers_can_view_campaign_landing_pages_spec.rb

+  let!(:maths_job1) { create(:vacancy, :past_publish, :no_tv_applications, job_roles: ["teacher"], publish_on: Date.current - 1, job_title: "Maths 1", subjects: %w[Mathematics], organisations: [school], phases: %w[secondary], expires_at: Date.current + 1, geolocation: "POINT(-0.019501 51.504949)") }
+  let!(:maths_job2) { create(:vacancy, :past_publish, :no_tv_applications, job_roles: ["teacher"], publish_on: Date.current - 2, job_title: "Maths Teacher 2", subjects: %w[Mathematics], organisations: [school], phases: %w[secondary], expires_at: Date.current + 3, geolocation: "POINT(-1.8964 52.4820)") }
+
+  it "contains the expected content and vacancies with personalized jobseeker name" do


wondering if we should add some simple interaction testing here to make sure that this custom page works as expected, as it seems to have quite a lot of content on it? Also I have just noticed that these jobs are both marked as 'secondary' phase, but the target was 'primary' so not sure why they are showing up? Maybe we should add some jobs outside the radius to show that the radius searches work?

I'll chat with Chloe first and then test the page. I suspect I will still need to tweak something.
After that, I think I'll be better positioned to add more testing.
Consider this a temporary page that will be live only for the campaign's duration.

Better to use `ActiveModel::Type::Boolean.new.cast(value)` to catch more truthy values

scruti · 2024-10-18T10:57:49Z

app/services/campaign_page.rb

+  end
+
+  def self.[](utm_content_code)
+    raise "No such campaign page: '#{utm_content_code}'" unless exists?(utm_content_code)


Shouldn't we gracefully handle this so users don't get a service error when the param value is wrong?
I would expect a user to get a 404 page or get redirected to the generic vacancies page.

Oh this seems unreachable due to the route constraint bellow.

get "campaigns/", to: "vacancies#campaign_landing_page", as: :campaign_landing_page, constraints: ->(request) { CampaignPage.exists?(request.params[:utm_content]) }

Forget my original comment then, this is a good enough safeguard!

scruti · 2024-10-18T11:06:27Z

app/controllers/vacancies_controller.rb

+    working_patterns << "full_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_fulltime)) == "true"
+    working_patterns << "part_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_parttime)) == "true"
+    working_patterns << "job_share" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_jobshare)) == "true"


I suspect these checks would never pass, since the boolean casting will return true instead of "true". So true == "true" doesn't match.

I think we don't even need the comparison:

Suggested change

working_patterns << "full_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_fulltime)) == "true"

working_patterns << "part_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_parttime)) == "true"

working_patterns << "job_share" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_jobshare)) == "true"

working_patterns << "full_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_fulltime))

working_patterns << "part_time" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_parttime))

working_patterns << "job_share" if ActiveModel::Type::Boolean.new.cast(campaign_params.delete(:email_jobshare))

scruti · 2024-10-18T11:18:52Z

config/campaign_pages.yml

@@ -0,0 +1,134 @@
+shared:
+  whentoapplybespoke+PRIMARY:
+    banner_image: "campaigns/primary_teacher.jpg"


ddippolito added the deploy label Oct 3, 2024

ddippolito temporarily deployed to review October 3, 2024 13:46 — with GitHub Actions Inactive

starswan reviewed Oct 7, 2024

View reviewed changes

ddippolito temporarily deployed to review October 8, 2024 08:23 — with GitHub Actions Inactive

ddippolito force-pushed the add-bespoke-landing-page-from-campaign branch from 61f59d7 to 240ed94 Compare October 8, 2024 10:42

ddippolito temporarily deployed to review October 8, 2024 10:45 — with GitHub Actions Inactive

ddippolito temporarily deployed to review October 14, 2024 08:59 — with GitHub Actions Inactive

ddippolito added 5 commits October 15, 2024 17:19

Add new campaign bespoke landing page

383acd1

Update vacancies controller campaign action

71be97a

Better to use `ActiveModel::Type::Boolean.new.cast(value)` to catch more truthy values

Parametirise subject in campaign page

6bd0eac

Add images for campaign

ac6a06c

Add Campaign page and configuration

f3d2f85

ddippolito force-pushed the add-bespoke-landing-page-from-campaign branch from 6a3d6fd to f3d2f85 Compare October 17, 2024 08:26

ddippolito temporarily deployed to review October 17, 2024 08:30 — with GitHub Actions Inactive

ddippolito had a problem deploying to review October 17, 2024 15:09 — with GitHub Actions Failure

Add more configuration utm codes

e4aef0f

ddippolito force-pushed the add-bespoke-landing-page-from-campaign branch from decb1a5 to e4aef0f Compare October 17, 2024 15:26

ddippolito had a problem deploying to review October 17, 2024 15:31 — with GitHub Actions Failure

Add documentation for landing pages

43a55d7

ddippolito had a problem deploying to review October 18, 2024 08:03 — with GitHub Actions Failure

ddippolito had a problem deploying to review October 18, 2024 08:32 — with GitHub Actions Failure

scruti reviewed Oct 18, 2024

View reviewed changes

Update landing page documentation

fb127dd

ddippolito temporarily deployed to review October 18, 2024 12:08 — with GitHub Actions Inactive

ddippolito temporarily deployed to review October 18, 2024 13:30 — with GitHub Actions Inactive

ddippolito closed this Jan 9, 2025

ddippolito deleted the add-bespoke-landing-page-from-campaign branch January 9, 2025 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new campaign bespoke landing page #7137

Add new campaign bespoke landing page #7137

ddippolito commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

starswan Oct 7, 2024 •

edited

Loading

ddippolito Oct 8, 2024

EllieNodder Oct 8, 2024

starswan Oct 7, 2024

ddippolito Oct 8, 2024

starswan Oct 7, 2024 •

edited

Loading

ddippolito Oct 8, 2024

starswan Oct 7, 2024 •

edited

Loading

ddippolito Oct 8, 2024

scruti Oct 18, 2024 •

edited

Loading

scruti Oct 18, 2024

scruti Oct 18, 2024

Add new campaign bespoke landing page #7137

Add new campaign bespoke landing page #7137

Conversation

ddippolito commented Oct 3, 2024

Trello card URL

Changes in this PR:

Screenshots of UI changes:

github-actions bot commented Oct 3, 2024

starswan Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starswan Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starswan Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scruti Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starswan Oct 7, 2024 •

edited

Loading

starswan Oct 7, 2024 •

edited

Loading

starswan Oct 7, 2024 •

edited

Loading

scruti Oct 18, 2024 •

edited

Loading