-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove factory bot from production #7150
Open
starswan
wants to merge
9
commits into
main
Choose a base branch
from
remove-factory-bot-from-production
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+113
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruti
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Review app deployed to https://teaching-vacancies-review-pr-7150.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
remove-factory-bot-from-production
branch
from
October 9, 2024 15:44
43036fb
to
fb51a31
Compare
starswan
force-pushed
the
remove-factory-bot-from-production
branch
from
October 11, 2024 14:08
fb51a31
to
84d760f
Compare
starswan
force-pushed
the
remove-factory-bot-from-production
branch
from
October 14, 2024 07:19
87ec525
to
b06c795
Compare
starswan
force-pushed
the
remove-factory-bot-from-production
branch
from
October 17, 2024 10:49
2702d0d
to
bf21d4c
Compare
…sible profile TRN
starswan
force-pushed
the
remove-factory-bot-from-production
branch
from
October 23, 2024 09:14
bf21d4c
to
95c9f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/t421CDhu/1275-remove-factorybot-from-production-environment
Changes in this PR:
Re-create the 'sample job application' using code rather than FactoryBot in the 'create a job' flow for publishers
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?