Faith non catholic flow #7235
Open
Faith non catholic flow #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddippolito
reviewed
Nov 11, 2024
| @@ -20,7 +18,7 @@ def update | |||
| job_application.update(update_params.except(:teacher_reference_number, :has_teacher_reference_number)) | |||
| update_or_create_jobseeker_profile! if step == :professional_status | |||
|
|
|||
| if redirect_to_review? && (step_process.last_of_group? || (step == :following_religion && !job_application.following_religion)) | |||
| if redirect_to_review? && (step_process.last_of_group? || (step.in?(%i[catholic_following_religion non_catholic_following_religion]) && !job_application.following_religion)) | |||
There was a problem hiding this comment.
Not a blocker, maybe we can give this condition a name to clarify its intent?
ddippolito
reviewed
Nov 11, 2024
| private | ||
|
|
||
| def catholic_steps(job_application) | ||
| if job_application.following_religion || job_application.following_religion.nil? |
There was a problem hiding this comment.
Isn't this always going to be truthy?
There was a problem hiding this comment.
no - it can be false. It's a tri-state - wasn't sure if it was the correct approach...?
ddippolito
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Well done @starswan. This must have a been a hell of beast to crack. I'm not sure it's possible to refactor the application form without reworking the whole thing from scratch.
Base automatically changed from
faith-school-catholic-flow
to
faith-schools-flow
November 12, 2024 10:58
|
Review app deployed to https://teaching-vacancies-review-pr-7235.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
faith-non-catholic-flow
branch
2 times, most recently
from
71ff8ea
to
aa7b127
Compare
EllieNodder
reviewed
Nov 20, 2024
| <p class="govuk-hint">Make sure your referee has consented to providing a reference.</p> | ||
| jobseekers_job_application_non_catholic_religion_details_form: | ||
| faith: For example, Christian. | ||
| place_of_worship: For example, Westminster Abbey, Dean's Yard, London. |
There was a problem hiding this comment.
probably remove this hint text? @starswan
starswan
force-pushed
the
faith-schools-flow
branch
from
3261421
to
d03f02e
Compare
starswan
force-pushed
the
faith-non-catholic-flow
branch
from
75e40b0
to
483fa8b
Compare
starswan
force-pushed
the
faith-schools-flow
branch
from
d03f02e
to
7ebf923
Compare
starswan
force-pushed
the
faith-non-catholic-flow
branch
from
483fa8b
to
89cce6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/MEfKqiY0/1326-faith-schools-add-religious-information-section-cofe-flow-middle-radio
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?