Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.1 fails to load into makecode #10

Open
nsteinmetz opened this issue Dec 27, 2019 · 12 comments
Open

1.2.1 fails to load into makecode #10

nsteinmetz opened this issue Dec 27, 2019 · 12 comments

Comments

@nsteinmetz
Copy link
Contributor

Hello,

Each time I try to load the maqueen (v 1.2.1) extension into makecode, I have:

SyntaxError: JSON.parse: expected double-quoted property name at line 25 column 1 of the JSON data
2 pxtapp.js:9159:26

On OSX, whatever the browser (safari, chrome or firefox)

@tangjie133
Copy link
Contributor

I tested but no problem!

@nsteinmetz
Copy link
Contributor Author

What is weird is that:

  • If I start an empty project, load the extension it fails
  • If I open a project which assumes having the extensions, it works - that's the way I could use the extension but I don't know which version I use then...

@tangjie133
Copy link
Contributor

Does this problem still exist?

@nsteinmetz
Copy link
Contributor Author

Yes :

Capture d’écran du 2020-01-14 10-55-09

@tangjie133
Copy link
Contributor

Where does your MaQueen come from, is it from the official website, can you give me a big screenshot, full screen?

@nsteinmetz
Copy link
Contributor Author

Hi,

What I do:

Capture d’écran du 2020-01-15 09-19-49

Thanks for trying to understand what happens and why it does not work. Really appreciated !

@tangjie133
Copy link
Contributor

Can you use other libraries from the official website?

@nsteinmetz
Copy link
Contributor Author

Yes, I could load bluetooth, bitbot and kitronic-servo-lite without any issue.

@patrickpollet1966
Copy link

Hi,

I just tried to work with a maqueen with my son and i have exactly the same problem as nsteinmetz.

(i tried with Chrome and Safari under OSX)

image

@erwangrouj
Copy link

I also have the problem if I use the french language. Switching Makecode to english language makes it work fine.

The problem comes from the ending comma in the french translation file (__locales/fr/maqueen-strings.json)

forking the maqueen repo then removing the ending comma made it work in french for me :

maqueen_locale_fr

@nsteinmetz
Copy link
Contributor Author

@erwangrouj brilliant, I was thinking about it the other day but did not take time to check this. Was more thinking about a bad escaped ' but comma works also ;-)

@nsteinmetz
Copy link
Contributor Author

@erwangrouj why not submit a pull request then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants