Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot holes if any within annotations #43

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Plot holes if any within annotations #43

merged 2 commits into from
Nov 7, 2023

Conversation

tsikup
Copy link
Contributor

@tsikup tsikup commented Nov 7, 2023

Fixed a bug where holes of an annotation were not plotted.

@martvanrijthoven
Copy link
Collaborator

Dear Nikos,

Thank you for noticing this issue!
Could you please move the added code to the if statement when the annotation is a polygon:

pathology-whole-slide-data/wholeslidedata/visualization/plotting.py

Line 71 in 53045d8

elif isinstance(annotation, PolygonAnnotation):

otherwise the code will break for points because points don’t have holes.

@tsikup
Copy link
Contributor Author

tsikup commented Nov 7, 2023

Done!

@martvanrijthoven martvanrijthoven merged commit 6e181e4 into DIAGNijmegen:main Nov 7, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsikup @martvanrijthoven