Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the SecuredOnboardingService.verify() call hides the upstream error message #136

Open
oliverrahner opened this issue Jul 30, 2024 · 1 comment

Comments

@oliverrahner
Copy link
Member

Is your feature request related to a problem? Please describe.
When a server side error happens in the SecuredOnboardingService.verify() call, the exception is created without taking into account the upstream error message present in the response body.

Describe the solution you'd like
It should be handled in the same way as in SecuredOnboardingService.onboard(), which includes the upstream error in the exception message.

@saschadoemer
Copy link
Member

@oliverrahner does the result have the same format as the onboard error has?

{
  "error": {
    "code": "0110",
    "message": "Signing header is invalid, the request has timedout, or UTCTimestamp is not provided",
    "target": "",
    "details": []
  }
}

The documentation does not have a clear statement to the format (https://docs.agrirouter.com/agrirouter-interface-documentation/latest/integration/onboarding.html#verification-result).

I would assume, that it is the same layout, therefore, see the PR and leave a review. If it is not the case, please let me know.

See #141 as implementation proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants