Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade target framework to .Net Standard 2.0 #87

Open
aparshin opened this issue Oct 10, 2021 · 3 comments
Open

Downgrade target framework to .Net Standard 2.0 #87

aparshin opened this issue Oct 10, 2021 · 3 comments
Assignees

Comments

@aparshin
Copy link
Contributor

We'd like to use this SDK in an application, which uses .Net Framework 4.7. The problem is that the target framework of the Agrirouter .Net SDK is .Net Standard 2.1, which is not compatible with any .Net Framework version.

What do you think about downgrade target framework of Agrirouter SDK to .Net Standard 2.0 instead of .Net Standard 2.1? According to Microsoft docs .Net Standard 2.0 as a recommended target framework for general-purpose libraries.

As a workaround for our integration, we had to include sources of Agrirouter SDK to our project and manually modify it to .Net Standard 2.0. It wasn't too difficult (only several places).

If you are interested in switching to .Net Standard 2.0, we'll be happy to create a corresponding PR.

@saschadoemer
Copy link
Member

At the moment, this would mean, that the corresponding libraries have to target version 2.0 as well. And this is not the case for the ProtoBuf definitions. I will keep that in mind and discuss with @oliverrahner additional steps.

@saschadoemer saschadoemer self-assigned this Jan 7, 2022
@hkors
Copy link

hkors commented Dec 10, 2024

As a workaround for our integration, we had to include sources of Agrirouter SDK to our project and manually modify it to .Net Standard 2.0. It wasn't too difficult (only several places).

I know this is an old issue, but can you maybe explain how you did this? I'm missing types from namespace Agrirouter.Request which are part of NuGet package agrirouter-api-protobuf-definitions, which is also a .NET Standard 2.1 project.

@saschadoemer
Copy link
Member

You could provide a private package just for your application by building the dependencies on your own and create a custom NuGet feed.

https://learn.microsoft.com/en-us/nuget/hosting-packages/overview

Switching to .NET Standard 2.0 is currently no option, since there are too many dependencies out there. If you need further help, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants