Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flow vault fetching by UUID #29

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

Polybius93
Copy link
Collaborator

This PR introduces significant improvements to the mint/unmint flow by altering the way vaults are fetched at each step. Instead of selecting the last one from the sorted category, the new approach involves fetching the corresponding vault by its unique identifier (uuid). To accommodate this modification, the structure of the mintunmint slice has been updated. Now, each step is represented by a tuple, combining the step's number and the corresponding uuid.

In addition, the behavior of the 'Lock BTC' buttons on the ready vaults has been enhanced. Instead of triggering the Bitcoin Wallet directly, these buttons now load the appropriate mint/unmint page with the requested vault. This enhancement required adjustments to the mint/unmint tab index handling. The mintunmint slice has been extended to include an activeTab field, which can be triggered from any component and is accessible by the tabs component.

Additional Changes
.prettierrc has been fixed and modified to use single quotes instead of double quotes.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for resilient-salamander-989e97 ready!

Name Link
🔨 Latest commit ebc4655
🔍 Latest deploy log https://app.netlify.com/sites/resilient-salamander-989e97/deploys/6571e30977f7850008bcb9a9
😎 Deploy Preview https://deploy-preview-29--resilient-salamander-989e97.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Polybius93 Polybius93 merged commit 3e98fad into dev Dec 7, 2023
11 checks passed
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for singular-biscuit-78f561 ready!

Name Link
🔨 Latest commit ebc4655
🔍 Latest deploy log https://app.netlify.com/sites/singular-biscuit-78f561/deploys/6571e30928f654000836ae9f
😎 Deploy Preview https://deploy-preview-29--singular-biscuit-78f561.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant