Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Problem Types In Contest When Enabled #2327

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

tandr3w
Copy link
Contributor

@tandr3w tandr3w commented Apr 2, 2024

Fixes #1872 (or attempts to)

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 46.76%. Comparing base (a981a64) to head (9c69413).
Report is 1 commits behind head on master.

Files Patch % Lines
judge/views/problem.py 33.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   46.76%   46.76%   -0.01%     
==========================================
  Files         251      251              
  Lines       13317    13320       +3     
==========================================
+ Hits         6228     6229       +1     
- Misses       7089     7091       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

judge/views/problem.py Outdated Show resolved Hide resolved
@int-y1
Copy link
Contributor

int-y1 commented Apr 2, 2024

can you post screenshots of the old and new problem list?

@tandr3w
Copy link
Contributor Author

tandr3w commented Apr 2, 2024

Before:
image

After:
image

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is completely borked, not to mention inefficient.

@tandr3w
Copy link
Contributor Author

tandr3w commented Apr 4, 2024

  • Moved show_types change into the setup_problem_list function
  • Replaced zip with an annotation
  • Fixed inconsistent padding due to the in-contest types table header not having the "types" class

@tandr3w tandr3w requested review from quantum5 and int-y1 April 4, 2024 14:47
@tandr3w
Copy link
Contributor Author

tandr3w commented Apr 4, 2024

New Screenshots:

Before changes:
image

With types disabled, after changes
image

With types enabled, after changes
image

@tandr3w
Copy link
Contributor Author

tandr3w commented Apr 6, 2024

Ready for re-review
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Types in Contests with "Show Types"
4 participants