Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChunkSeqNo should not wrap #2875

Open
steven-bellock opened this issue Oct 31, 2024 · 2 comments
Open

ChunkSeqNo should not wrap #2875

steven-bellock opened this issue Oct 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@steven-bellock
Copy link
Contributor

I believe a reading of the Large SPDM message transfer mechanism implies that ChunkSeqNo should not wrap. Ie, if the message is too large for 65536 chunks then it should not be sent. However libspdm assumes wrapping, for example

I filed https://github.com/DMTF/SPDM-WG/issues/3703 to increase the size of ChunkSeqNo so that we don't have to think about this for SPDM 1.4 and greater.

@steven-bellock steven-bellock added the bug Something isn't working label Oct 31, 2024
@jyao1
Copy link
Member

jyao1 commented Nov 1, 2024

Good finding.

Read the spec, the LargeMessageSize is present when ChunkSeqNo is 0. But it is not considered on wrap case.

I think we should prevent wrap from happening.

@steven-bellock
Copy link
Contributor Author

The SPDM Working Group confirmed that it does not wrap. This will be made more explicit in the specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants