Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wy 2021 river conditions #21

Merged
merged 3 commits into from
Jan 6, 2022
Merged

add wy 2021 river conditions #21

merged 3 commits into from
Jan 6, 2022

Conversation

cnell-usgs
Copy link
Member

@cnell-usgs cnell-usgs commented Jan 6, 2022

Changes made:

adding the 2021 water year river conditions to the events carousel and making naming more intuitive

image

Testing:

Before making this pull request, I:

  • Cleaned the code the way Vue likes it - run 'npm run lint --fix'
  • Made sure all tests run
  • Ran WAVE plugin 508 compliance tool

I can confirm this has been checked on:

  • Chrome
  • Safari
  • Edge
  • Firefox
  • Samsung Internet
  • Internet Explorer 11 (not supported, but still needs at least a working user redirect page)

@cnell-usgs
Copy link
Member Author

cnell-usgs commented Jan 6, 2022

Merging this. Minimal change to rename "hurricanes" to "Events" to include river conditions.

FYI to @hcorson-dosch: to add elements you just add the information to the csv committed to the repo. The group column defines which carousel it gets placed in, and img is the thumbnail file. This reads in files from s3 with the root path https://labs.waterdata.usgs.gov/visualizations/thumbnails/. The steps to push thumbnail files to s3 has not been added formally into this pipeline (#22)

@cnell-usgs cnell-usgs merged commit 92593ae into DOI-USGS:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant