Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signs localization #228

Closed
WillPowerCraft opened this issue Mar 10, 2017 · 6 comments
Closed

Signs localization #228

WillPowerCraft opened this issue Mar 10, 2017 · 6 comments
Milestone

Comments

@WillPowerCraft
Copy link

WillPowerCraft commented Mar 10, 2017

how about give us to edit signs?

i have plugin on main server for regions AreaShop
that give me way to edit all signs used by plugin like i need:

for example that part of .yml file:

##### Set the layout and functions of the signs.
  # The following sections can be added for performing certain commands when the sign is clicked:
  #     rightClickPlayer, rightClickConsole, shiftRightClickPlayer, shiftRightClickConsole,
  #     leftClickPlayer, leftClickConsole, shiftLeftClickPlayer, shiftLeftClickConsole.
  # Sections with 'Player' at the end will be run by the player that clicks the sign and 'Console' ones from the console.
  signProfile:
    forrent:
      line1: '&2&l[For Rent]'
      line2: '%region%'
      line3: '%duration%'
      line4: '%price%'
      rightClickPlayer:
        - 'areashop rent %region%'
      rightClickConsole:
      #  - 'areashop message %clicker% %lang:confirm-rent|%region%|%' # Alternative to first ask for confirmation (remove rightClickPlayer section)
      leftClickPlayer:
        - 'areashop info region %region%'

I hope ure add that option in nearest update ^_^

@Sataniel98
Copy link
Member

What is the purpose though?

@WillPowerCraft
Copy link
Author

WillPowerCraft commented Mar 10, 2017

Change standart sign text like that:

############
Leave

############

to

&7&m------------
&cПокинуть
&cгруппу
&7&m------------

Покинуть группу = Leave group in russian =)

and more ways to commands on signs:

for example on Group sign:
left click - join group
right click - leave group

@Sataniel98
Copy link
Member

Sataniel98 commented Mar 10, 2017

So basically, you want the signs to be translatable. I never really thought about that. Even back in the days when this plugin was German only, the signs were already English for some reason and we didn't mind
¯\_(ツ)_/¯ These signs do not use commands internally. I might add the sign texts to the language file, that's not much work, but I really don't see a need to change the mechanics of the few global signs that we have.

@WillPowerCraft
Copy link
Author

WillPowerCraft commented Mar 10, 2017

ok, that will be awesome to have sign's strings in translate file 👍

@WillPowerCraft
Copy link
Author

hmmm

so do i need close issue in moment when ure answer about ure will add/fix

or i/ure should close issue when thats updated fixed ?

@Sataniel98 Sataniel98 reopened this Mar 10, 2017
@Sataniel98
Copy link
Member

Keep it open :) We'll mark it as an enhancement

@Sataniel98 Sataniel98 changed the title Signs edit text (languages for example) Signs localization Mar 10, 2017
@Sataniel98 Sataniel98 added this to the Beta 0.16 milestone Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants