Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Increase of color contrast on parts of site #3809

Open
hostle83 opened this issue Jan 7, 2025 · 3 comments · May be fixed by #3847
Open

[Accessibility] Increase of color contrast on parts of site #3809

hostle83 opened this issue Jan 7, 2025 · 3 comments · May be fixed by #3847
Assignees
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug help wanted Needs a volunteer to claim to move forward quick win Pull request is small in size & should be easy to review and/or merge

Comments

@hostle83
Copy link

hostle83 commented Jan 7, 2025

Describe the bug

According to WCAG 2.0, color contrast for large text (defined as 14 pt and bold or larger, or 18 point or larger) should at least be 3:1 (4:5:1 for normal text). Parts of the current site fail a color contrast check.

Contrast Ratio

To Reproduce

Steps to reproduce the behavior:
I used the Silktide plugin on demo.dspace.org to check color contrasts on each site.

Expected behavior

Increase color contrast to at least 3:1 for large text. Ideally (level AAA), to 4:5:1. See also https://webaim.org/resources/contrastchecker/

@hostle83 hostle83 added bug needs triage New issue needs triage and/or scheduling labels Jan 7, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Jan 7, 2025
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward accessibility quick win Pull request is small in size & should be easy to review and/or merge and removed needs triage New issue needs triage and/or scheduling labels Jan 7, 2025
@tdonohue tdonohue removed this from DSpace Backlog Jan 7, 2025
@tdonohue tdonohue added affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases labels Jan 7, 2025
@Andrea-Guevara
Copy link
Contributor

@hostle83, @tdonohue Good afternoon! we at Neki-it would like to help solve this problem. Before providing a pull we want to know if you agree with us adding the color $gray-700 (#495057) as the text color? currently the placeholder color is set to “lighten($gray-700, 10%)” but, we could leave only $gray-700 to try to improve the contrast! we would do the same for the other texts that are giving problems.

Image

Image

@hostle83
Copy link
Author

Hi @Andrea-Guevara, this looks good to me. The contrast ratio will pass level AAA, which is great. Thank you for taking this on, much appreciated!

@Andrea-Guevara Andrea-Guevara linked a pull request Jan 17, 2025 that will close this issue
12 tasks
@Andrea-Guevara
Copy link
Contributor

Good morning @hostle83! we've just released a pull that will help improve the color contrast of the placeholders.

This pull does not correct the color contrast of the buttons mentioned above, as they are initially disabled.

If necessary, we'll be happy to make any adjustments!

@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug help wanted Needs a volunteer to claim to move forward quick win Pull request is small in size & should be easy to review and/or merge
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

3 participants